Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update sip_banners record for Cisco Telepresence #625

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

atorovik-r7
Copy link
Contributor

Description

A detailed description of your changes.
Updated sip-banner record for Cisco Telepresence to reflect the current product naming, vendor, family. Make regex more strict to match only versions starting with X and TC.
SIP protocol example:

SIP/2.0 403 Forbidden
Via: SIP/2.0/UDP nm;branch=foo;received=224.85.86.107;rport=26810;ingress-zone=DefaultZone
Call-ID: 50000
CSeq: 42 OPTIONS
From: sip:nm@nm;tag=root
To: sip:nm2@nm2;tag=dba04991a2a1090f
Server: TANDBERG/4145 (X15.0.3)

Motivation and Context

How Has This Been Tested?

Tested with bin/recog_verify

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated the documentation accordingly (or changes are not required).
  • I have added tests to cover my changes (or new tests are not required).
  • All new and existing tests passed.

@atorovik-r7 atorovik-r7 force-pushed the Fix-device-name-for-cisco-telepresence branch from 9bf29e1 to a58e205 Compare September 2, 2024 12:01
Copy link
Contributor

@martinvotruba-r7 martinvotruba-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atorovik-r7 atorovik-r7 merged commit 061a67e into main Sep 3, 2024
24 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants